OHRM5X-1888: Upgrade oxd dependencies #658
Conversation
| @@ -7,8 +7,7 @@ module.exports = { | |||
| 'plugin:vue/vue3-essential', | |||
| 'eslint:recommended', | |||
| '@vue/typescript/recommended', | |||
| '@vue/prettier', | |||
| '@vue/prettier/@typescript-eslint', | |||
| 'plugin:prettier/recommended', | |||
There was a problem hiding this comment.
@vue/eslint-config-prettier package remove due to deprecation. eslint-plugin-vue is added.
https://cli.vuejs.org/migrations/migrate-from-v4.html#eslint-plugin
| opera >= 12 | ||
| safari >= 5 | ||
| chrome >= 56 | ||
| > 1% |
There was a problem hiding this comment.
Recommended latest browserlist config vuejs/vue-cli#5233
There was a problem hiding this comment.
We have to define the minimum supported browser versions.
There was a problem hiding this comment.
1% is all versions with >1% of the audience worldwide.
We can further specify versions, but needs to be updated manually. Let's discuss
From browserlist tool
| @@ -1,7 +1,4 @@ | |||
| module.exports = { | |||
| preset: '@vue/cli-plugin-unit-jest/presets/typescript-and-babel', | |||
| transform: { | |||
| '^.+\\.vue$': 'vue-jest', | |||
| }, | |||
There was a problem hiding this comment.
vue-jest deprecated. vue3-jest is installed
https://github.com/vuejs/vue-jest#installation
| @@ -15,10 +15,11 @@ | |||
| "tsc": "yarn workspace oxd-components tsc" | |||
| }, | |||
| "engines": { | |||
| "node": ">=10.19.0", | |||
| "yarn": ">=1.22.4" | |||
| "node": ">=16.17.0", | |||
There was a problem hiding this comment.
Minimum: Node 16 (Active updates)
Recommended: Node 18 (Current LTS)
https://endoflife.date/nodejs
Yarn 3.3 Latest (version barry)
| @@ -1,6 +1,9 @@ | |||
| const path = require('path'); | |||
|
|
|||
| module.exports = { | |||
| core: { | |||
| builder: 'webpack5', | |||
There was a problem hiding this comment.
Storybook recommended configuration
https://github.com/storybookjs/storybook/tree/main/lib/builder-webpack5#builder-webpack5
Super-Chama
force-pushed
the
develop
branch
2 times, most recently
from
d108030
to
af496b2
Compare
| "eslint-config-prettier": "^8.3.0", | ||
| "eslint-plugin-prettier": "^4.0.0", | ||
| "eslint-plugin-vue": "^8.0.3", | ||
| "jest": "^27.1.0", |
There was a problem hiding this comment.
Cannot update to vue-jest 29 based on jest 29 due to @vue/cli-plugin-unit-jest plugin for vue-cli is not supported yet. (most likely will not be supported ever as upstream development is now focused on vite)
| @@ -40,6 +40,10 @@ const options = [ | |||
| ]; | |||
|
|
|||
| describe('SelectInput.vue', () => { | |||
| const div = document.createElement('div'); | |||
There was a problem hiding this comment.
Due to a bug in jsdom v16 and above, focus is not emitted unless 'attachedTo' value is added to wrapper. Newer version of vue test utils documentation is missing this. (below exempt is taken from vue2 docs)
refer discussion in vuejs/vue-test-utils#1777
| opera >= 12 | ||
| safari >= 5 | ||
| chrome >= 56 | ||
| > 1% |
There was a problem hiding this comment.
We have to define the minimum supported browser versions.
Checklist