Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.0.0.2 & Bundler activation #2586

Closed
MSP-Greg opened this issue Jan 27, 2022 · 4 comments
Closed

22.0.0.2 & Bundler activation #2586

MSP-Greg opened this issue Jan 27, 2022 · 4 comments
Assignees
Milestone

Comments

@MSP-Greg
Copy link

Puma is failing on TruffleRuby jobs. This seemed to happen when TruffleRuby went from 21.3.0 to 22.0.0.2. It may also involve recent changes to ruby/setup-ruby. Not.Sure.

Passing job using 21.3.0 - https://github.com/puma/puma/runs/4938565379

Failing job using 22.0.0.1 - https://github.com/puma/puma/runs/4943479989

Both jobs use the same workflow, and both install Bundler 2.3.5, but the failing job logs

You have already activated bundler 2.2.22, but your Gemfile requires bundler 2.3.5.
@eregon
Copy link
Member

eregon commented Jan 27, 2022

Thank you for the report, @bjfish and I will take a look.
I suspect it's something new in Bundler or in RubyGems that broke this.

"your Gemfile requires bundler 2.3.5." sounds confusing, I guess it's just because the Gemfile.lock was created with Bundler 2.3.5.

Maybe not using the latest Bundler release (e.g., just use Bundler 2.2.22 shipped with TruffleRuby) would help here.
That's not possible with current setup-ruby (bundler: none means bundler-cache: true has no effect), but that should be easily fixable.

@eregon
Copy link
Member

eregon commented Jan 27, 2022

FWIW this worked: https://github.com/ruby/setup-ruby/runs/4942414592?check_suite_focus=true
truffleruby 22.0 + bundler 2.3.5 for bundle install + bundle exec. Weird.
I'll support bundler: none + bundler-cache: true in setup-ruby so at least we have a workaround:
ruby/setup-ruby@fabf251

eregon added a commit to eregon/puma that referenced this issue Jan 27, 2022
eregon added a commit to eregon/puma that referenced this issue Jan 27, 2022
@eregon
Copy link
Member

eregon commented Jan 27, 2022

Workaround in puma/puma#2811 but we'll keep investigating on how to fix Bundelr 2.3.5+ and TruffleRuby 22.0/latest.

dentarg pushed a commit to puma/puma that referenced this issue Jan 27, 2022
* Should workaround oracle/truffleruby#2586

* Make the test_lowlevel_error_message test more reliable
eregon added a commit to ruby/setup-ruby that referenced this issue Jan 28, 2022
@eregon eregon added this to the 22.1.0 milestone Feb 17, 2022
@eregon
Copy link
Member

eregon commented Feb 17, 2022

This is fixed on truffleruby-dev with 752a2f3.

For 22.0 I did the workaround of always using the shipped Bundler for TruffleRuby in ruby/setup-ruby:
https://github.com/ruby/setup-ruby/releases/tag/v1.97.0

Ideally rake-compiler would fix this and then the workaround would probably not be needed anymore.

@eregon eregon closed this as completed Feb 17, 2022
@eregon eregon self-assigned this Feb 17, 2022
MSP-Greg pushed a commit to MSP-Greg/puma that referenced this issue Apr 2, 2022
* Should workaround oracle/truffleruby#2586

* Make the test_lowlevel_error_message test more reliable
MSP-Greg pushed a commit to MSP-Greg/puma that referenced this issue Apr 3, 2022
* Should workaround oracle/truffleruby#2586

* Make the test_lowlevel_error_message test more reliable
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this issue Sep 9, 2022
* Should workaround oracle/truffleruby#2586

* Make the test_lowlevel_error_message test more reliable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants