Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sep-10): use 5 minutes grace period for challenge tx #256

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

charlie-wasp
Copy link
Contributor

@charlie-wasp charlie-wasp commented Feb 10, 2022

Resolves #212

@nebolsin nebolsin changed the title [SEP-10] Use 5 minutes grace period for challenge tx feat(sep-10): use 5 minutes grace period for challenge tx Feb 18, 2022
@nebolsin
Copy link
Member

Seems like the specs are failing on TruffleRuby.

@nebolsin nebolsin merged commit 0d02663 into main Feb 18, 2022
@nebolsin nebolsin deleted the feat/sep-10-min-time-grace-period branch February 18, 2022 10:38
@charlie-wasp
Copy link
Contributor Author

Wow, I wonder, how you fixed it! When I checked the build last time, it seemed to be failing on bundle stage 🤔

@nebolsin
Copy link
Member

Bundler issue has been fixed upstream: oracle/truffleruby#2586. But then there was another issue, probably related to slightly different type coercion in truffleruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEP-10: apply grace period to minTime constraint
2 participants