Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge six (even the vendored one) from non-vendored files #642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MeggyCal
Copy link

As this library is Python 3 only, it shouldn't need six to run. It is a preparation for Python 3.13, however, some dependencies still need six.

Some files I edited by hand, but most work was done by sed scripts, namely:
sed -i '/import six/d'
sed -i 's/six.iter\([a-z]\+\)(\([_\.a-z]\+\))/\2.\1()/g'
sed -i 's/six.string_types/str/g' and friends (the same with binary_type, integer_types, etc)

If there is any mistake, typo, anything, let me know :) .

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Apr 18, 2024
@MeggyCal
Copy link
Author

Well, I am reluctant to create an account... I will think about that.

@MeggyCal
Copy link
Author

MeggyCal commented Apr 18, 2024

Anyway, I give anyone my permission to use those sed scripts (or even copy my commit) and basically bypass my PR. I just want this library to work even after six dies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant