Lock the trial heartbeat model #5447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using RDB in Optuna, the thread that records Heartbeat for Trial runs in parallel with the threads running Study and Trial. When writing values to Study and Trial tables, we are calling
with_for_updateso that the FOR UPDATE clause is appended to the SELECT sentences, but not when writing values to Heartbeat tables. This may cause an unexpected lock when writing values to Heartbeat tables, resulting in a deadlock. This PR suggests callingwith_for_updatewhen writing to Heartbeat tables.Description of the changes
with_for_updateto the Heartbeat table.