Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce __future__.annotations to TPE-related modules #5443

Conversation

nabenabe0928
Copy link
Collaborator

Motivation

Relates to:

Description of the changes

Introduce __future__.annotations to TPE-related modules.

@nabenabe0928
Copy link
Collaborator Author

nabenabe0928 commented May 13, 2024

@y0z @eukaryo Could you review this PR?

Copy link
Collaborator

@eukaryo eukaryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eukaryo eukaryo removed their assignment May 13, 2024
@eukaryo eukaryo added the code-fix Change that does not change the behavior, such as code refactoring. label May 13, 2024
@eukaryo eukaryo added this to the v4.0.0 milestone May 13, 2024
Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z removed their assignment May 15, 2024
@y0z y0z merged commit f954e35 into optuna:master May 15, 2024
14 checks passed
@nabenabe0928 nabenabe0928 deleted the code-fix/introduce-future-annotations-to-tpe-related-modules branch May 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants