-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle experimental feature warning #5434
Bundle experimental feature warning #5434
Conversation
64dfe9e
to
55e1036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using argument
instead of option
? I feel a bit odd to call some of the features option.
Co-authored-by: Naoto Mizuno <gobou522@gmail.com>
c219aec
to
c4de828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Motivation
As experimental feature warning scattered around the codebase, I bundled them in a single place.
Description of the changes
I simply created a function to warn experimental features and use them for every single line.