Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin sphinx version to 3.0.4 #1627

Merged
merged 1 commit into from Aug 13, 2020
Merged

Pin sphinx version to 3.0.4 #1627

merged 1 commit into from Aug 13, 2020

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Aug 12, 2020 •
edited

Motivation

Fixes #1614

Description of the changes

Pin sphinx version to 3.0.4

@harupy
Copy link
Contributor Author

harupy commented Aug 12, 2020 •
edited

I'm experiencing the exact same issue in the mlflow repo:

Screen Shot 2020-08-12 at 19 00 05

https://github.com/optuna/optuna/pull/1627/checks?check_run_id=975275803#step:6:485

I've observed the same issue occurs in CircelCI and thought it originates from PyPI, but it looks like that is not the case:
https://discuss.python.org/t/error-these-packages-do-not-match-the-hashes-from-the-requirements-file/4926/4

@crcrpar crcrpar self-assigned this Aug 12, 2020
@crcrpar crcrpar added the other Issue/PR that does not fit into any other label. label Aug 12, 2020
crcrpar
crcrpar approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@crcrpar crcrpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your continuous effort for us.

Year, that download errors have annoyed us but this time that failure doesn't matter as Circle CI ran successfully which are required.

hvy
hvy approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very appropriate given the past discussion.

Thanks a lot, as always. LGTM!

@hvy hvy merged commit 23abe03 into optuna:master Aug 13, 2020
@hvy hvy added this to the v2.1.0 milestone Aug 13, 2020
@harupy harupy deleted the patch-1 branch August 13, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvy hvy hvy approved these changes

@crcrpar crcrpar crcrpar approved these changes

Assignees

@crcrpar crcrpar

Labels
other Issue/PR that does not fit into any other label.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

Fix docstrings
3 participants
@harupy @hvy @crcrpar