Skip to content

Commit

Permalink
Merge #453
Browse files Browse the repository at this point in the history
453: Extract 'make ci' to CircleCI's steps r=saneyuki a=saneyuki

This improves the readability of CI results



Co-authored-by: Tetsuharu OHZEKI <tetsuharu.ohzeki@gmail.com>
  • Loading branch information
bors[bot] and tetsuharuohzeki committed Sep 17, 2019
2 parents d815ae8 + a221d9f commit 13da2bd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
14 changes: 12 additions & 2 deletions .circleci/config.yml
Expand Up @@ -52,6 +52,16 @@ commands:
fi
yarn install
###########################################
# Test Commands
###########################################
test_all:
description: "Test all required items"
steps:
- run: make clean -j
- run: make test -j
- run: make git_diff -j


###########################################
# Cache Commands
Expand Down Expand Up @@ -131,15 +141,15 @@ jobs:
- checkout
- *cmd_attach_workspace
- install_npm_dependency
- run: make ci -j 8
- test_all

latest_build_and_test_for_every_change:
executor: latest_nodejs_executor
steps:
- checkout
- *cmd_attach_workspace
- install_npm_dependency
- run: make ci -j 8
- test_all


###########################################
Expand Down
10 changes: 0 additions & 10 deletions Makefile
Expand Up @@ -213,16 +213,6 @@ run_test_distribution_contain_all:
OUTDIR=$(DIST_DIR) $(NODE_BIN) $(CURDIR)/tools/pkg_files_tester.js


###########################
# CI
###########################
.PHONY: ci
ci:
$(MAKE) clean
$(MAKE) test
$(MAKE) git_diff


###########################
# Tools
###########################
Expand Down

0 comments on commit 13da2bd

Please sign in to comment.