Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #13341: Added Mypy type annotations to the script directory's root level files. #16169

Merged
merged 41 commits into from
Oct 11, 2022

Conversation

sahiljoster32
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of Add type annotations to files of scripts folder #13341.
  2. This PR does the following: This PR adds MyPy type annotations to the root-level files of the script directory.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

No proof of changes needed because tests are passing on local machine.

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Oct 1, 2022

Hi @sahiljoster32. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

Copy link
Contributor

@aasiffaizal aasiffaizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2022

Unassigning @aasiffaizal since they have already approved the PR.

scripts/check_if_pr_is_low_risk_test.py Outdated Show resolved Hide resolved
scripts/servers_test.py Outdated Show resolved Hide resolved
scripts/servers_test.py Outdated Show resolved Hide resolved
scripts/servers_test.py Outdated Show resolved Hide resolved
@U8NWXD U8NWXD assigned sahiljoster32 and unassigned U8NWXD Oct 9, 2022
@sahiljoster32 sahiljoster32 assigned U8NWXD and unassigned sahiljoster32 Oct 9, 2022
@sahiljoster32
Copy link
Contributor Author

@U8NWXD PTAL!

@U8NWXD U8NWXD assigned sahiljoster32 and unassigned U8NWXD Oct 10, 2022
@sahiljoster32
Copy link
Contributor Author

@U8NWXD PTAL!

@oppiabot
Copy link

oppiabot bot commented Oct 10, 2022

Hi @sahiljoster32, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@sahiljoster32 sahiljoster32 removed their assignment Oct 10, 2022
@U8NWXD U8NWXD assigned sahiljoster32 and unassigned U8NWXD Oct 10, 2022
@oppiabot
Copy link

oppiabot bot commented Oct 10, 2022

Hi @sahiljoster32, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@sahiljoster32 sahiljoster32 merged commit 0bd27d9 into oppia:develop Oct 11, 2022
@sahiljoster32 sahiljoster32 deleted the scripts-root-level-files branch October 11, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants