New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5312, part of #59: Introduce better script execution support #5313
Fix part of #5312, part of #59: Introduce better script execution support #5313
Commits on Aug 22, 2023
-
Fix a variety of dev platform-specific issues.
These issues were found after I started using a new development environment.
Configuration menu - View commit details
-
Copy full SHA for 667bf89 - Browse repository at this point
Copy the full SHA 667bf89View commit details
Commits on Aug 28, 2023
-
Tidy some things up, and revert fragment test.
ProfileAndDeviceIdFragmentTest had been updated to use a newer fragment initialization pattern, but that's no longer needed and seems to be causing what appears to be timing discrepancies between local dev and CI.
Configuration menu - View commit details
-
Copy full SHA for fb59232 - Browse repository at this point
Copy the full SHA fb59232View commit details
Commits on Sep 11, 2023
-
Fix test behavior inconsistency in test.
The issue ultimately arose from test parameters being initialized after they're needed in the launched UI. This type of change was tried earlier in the branch, but reverted since it didn't seem necessary. It is, however, necessary when there are environment differences (e.g. local vs. CI) or when running certain tests individually. Due to the difficulty in finding this issue, ActivityScenarioRule has been added as a prohibited pattern in the static regex checks (along with ActivityTestRule since that's deprecated and discouraged, anyway).
Configuration menu - View commit details
-
Copy full SHA for 2551d4b - Browse repository at this point
Copy the full SHA 2551d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 714f3ea - Browse repository at this point
Copy the full SHA 714f3eaView commit details
Commits on Sep 13, 2023
-
Fix broken ProfileAndDeviceIdFragmentTest test.
The test was suffering from some proto encoding inconsistencies that seem to occur between some development machines vs. on CI. The fix improves the test's robustness by extracting the raw encoded string, verifying that the other outputs in the intent message correctly correspond to that string, and that the string (as a parsed proto) contains the correct values. As a result, the test no longer depends on a hardcoded encoding value to be present for verification. This does result in a bit more logic than is generally good to have in a test (and it lengthened the test code quite a bit), but it seems necessary in this particular case.
Configuration menu - View commit details
-
Copy full SHA for 7488b9f - Browse repository at this point
Copy the full SHA 7488b9fView commit details
Commits on Oct 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e3d4091 - Browse repository at this point
Copy the full SHA e3d4091View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5671673 - Browse repository at this point
Copy the full SHA 5671673View commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd1466d - Browse repository at this point
Copy the full SHA bd1466dView commit details
Commits on Jan 18, 2024
-
Add ScriptBackgroundCoroutineDispatcher.
This is a script-specific dispatcher which will allow for better asynchronous support in upcoming PRs (especially for command execution). This change serves to prepare for those changes.
Configuration menu - View commit details
-
Copy full SHA for 000bba3 - Browse repository at this point
Copy the full SHA 000bba3View commit details
Commits on Jan 19, 2024
-
The main change here is ensuring that Bazel 4.0.0 is used & bzlmod disabled in newer versions of Bazel when running operations in a test Bazel environment. This commit also introduces some more timing tweaks on CommandExecutor for some tests, though these only affect very specific tests (as many script tests directly call a script's main() function and thus don't overwrite its executor behavior). This commit attempted to introduce "--batch" mode to runs, but the isolation didn't actually seem to improve stability and, instead, substantially slowed down some of the tests.
Configuration menu - View commit details
-
Copy full SHA for 79878cd - Browse repository at this point
Copy the full SHA 79878cdView commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support Conflicts: scripts/src/java/org/oppia/android/scripts/ci/ComputeAffectedTests.kt scripts/src/javatests/org/oppia/android/scripts/ci/ComputeAffectedTestsTest.kt scripts/src/javatests/org/oppia/android/scripts/common/BazelClientTest.kt
Configuration menu - View commit details
-
Copy full SHA for a5f71d6 - Browse repository at this point
Copy the full SHA a5f71d6View commit details -
Plus, actually makes use of the new script background dispatcher in CommandExecutorImpl to make the new wiring make more sense (though its real utility will come in a follow-up PR).
Configuration menu - View commit details
-
Copy full SHA for 0b55bd4 - Browse repository at this point
Copy the full SHA 0b55bd4View commit details
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd97611 - Browse repository at this point
Copy the full SHA bd97611View commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support
Configuration menu - View commit details
-
Copy full SHA for d54829d - Browse repository at this point
Copy the full SHA d54829dView commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 211487c - Browse repository at this point
Copy the full SHA 211487cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a666a9 - Browse repository at this point
Copy the full SHA 1a666a9View commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2ee5d3 - Browse repository at this point
Copy the full SHA a2ee5d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b9012 - Browse repository at this point
Copy the full SHA d5b9012View commit details -
Fixed broken instrumentation builds.
This was done by removing the //testing dependency and, instead, having instrumentation targets depend on the direct module within //testing that they need to build. This module & its corresponding implementation binding (and tests) needed to be moved out of //testing and into their own /firebase package.
Configuration menu - View commit details
-
Copy full SHA for e6ec869 - Browse repository at this point
Copy the full SHA e6ec869View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f50469 - Browse repository at this point
Copy the full SHA 9f50469View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dbf4dc - Browse repository at this point
Copy the full SHA 8dbf4dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c38057 - Browse repository at this point
Copy the full SHA 9c38057View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2ff4e3 - Browse repository at this point
Copy the full SHA f2ff4e3View commit details
Commits on Feb 8, 2024
-
Add missing tests for TestBlazeWorkspace changes.
Also includes some minor clean-ups within TestBazelWorkspaceTest.
Configuration menu - View commit details
-
Copy full SHA for fad48ed - Browse repository at this point
Copy the full SHA fad48edView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1802c8 - Browse repository at this point
Copy the full SHA e1802c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00c32f6 - Browse repository at this point
Copy the full SHA 00c32f6View commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support
Configuration menu - View commit details
-
Copy full SHA for 2f87f4d - Browse repository at this point
Copy the full SHA 2f87f4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3cbd93 - Browse repository at this point
Copy the full SHA d3cbd93View commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support
Configuration menu - View commit details
-
Copy full SHA for 13e4358 - Browse repository at this point
Copy the full SHA 13e4358View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50f41d2 - Browse repository at this point
Copy the full SHA 50f41d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8df70e - Browse repository at this point
Copy the full SHA c8df70eView commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c85d421 - Browse repository at this point
Copy the full SHA c85d421View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf27b6 - Browse repository at this point
Copy the full SHA dcf27b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2369514 - Browse repository at this point
Copy the full SHA 2369514View commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support
Configuration menu - View commit details
-
Copy full SHA for c7ec5d4 - Browse repository at this point
Copy the full SHA c7ec5d4View commit details -
Required upgrade of kotlinx-coroutines-core.
Configuration menu - View commit details
-
Copy full SHA for 8de4d51 - Browse repository at this point
Copy the full SHA 8de4d51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f69f11 - Browse repository at this point
Copy the full SHA 3f69f11View commit details
Commits on Feb 14, 2024
-
Update scripts/src/javatests/org/oppia/android/scripts/common/GitClie…
…ntTest.kt Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2916770 - Browse repository at this point
Copy the full SHA 2916770View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d810a - Browse repository at this point
Copy the full SHA f2d810aView commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support Conflicts: third_party/maven_install.json
Configuration menu - View commit details
-
Copy full SHA for 808f412 - Browse repository at this point
Copy the full SHA 808f412View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6856e3c - Browse repository at this point
Copy the full SHA 6856e3cView commit details -
Merge branch 'fix-platform-specific-issues' into introduce-better-scr…
…ipt-execution-support
Configuration menu - View commit details
-
Copy full SHA for 5a050de - Browse repository at this point
Copy the full SHA 5a050deView commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a5eb624 - Browse repository at this point
Copy the full SHA a5eb624View commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e0e74d5 - Browse repository at this point
Copy the full SHA e0e74d5View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 70df9b3 - Browse repository at this point
Copy the full SHA 70df9b3View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51a96ce - Browse repository at this point
Copy the full SHA 51a96ceView commit details