Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#54469] Allow sending notifications for invited users #15500

Merged
merged 6 commits into from May 22, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented May 7, 2024

@oliverguenther oliverguenther force-pushed the feature/notify-on-meeting-creation branch from 33836c4 to d0a2e90 Compare May 7, 2024 14:11
@oliverguenther oliverguenther changed the title Feature/notify on meeting creation Allow sending notifications for invited users May 7, 2024
@mrmir mrmir changed the title Allow sending notifications for invited users [#54469] Allow sending notifications for invited users May 7, 2024
@mrmir mrmir marked this pull request as ready for review May 14, 2024 18:18
@dombesz dombesz self-requested a review May 21, 2024 09:49
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrmir looks good! 👍 Just 2 minor things, feel free to merge after they are addressed.

modules/meeting/app/controllers/meetings_controller.rb Outdated Show resolved Hide resolved
modules/meeting/app/views/meetings/_form.html.erb Outdated Show resolved Hide resolved
@mrmir mrmir requested a review from dombesz May 21, 2024 19:14
@mrmir mrmir merged commit 1e80d6d into dev May 22, 2024
8 checks passed
@mrmir mrmir deleted the feature/notify-on-meeting-creation branch May 22, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants