New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Op#54456] Display the mapped projects list in the project attributes detail view #15476
Merged
akabiru
merged 22 commits into
dev
from
task/54456-develop-a-strategy-on-how-to-reuse-the-current-project-list-implementation
May 21, 2024
Merged
[Op#54456] Display the mapped projects list in the project attributes detail view #15476
akabiru
merged 22 commits into
dev
from
task/54456-develop-a-strategy-on-how-to-reuse-the-current-project-list-implementation
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in projects attribute settings view https://community.openproject.org/work_packages/54459
apfohl
force-pushed
the
task/54456-develop-a-strategy-on-how-to-reuse-the-current-project-list-implementation
branch
from
May 6, 2024 11:25
7ccd435
to
d85d12d
Compare
akabiru
force-pushed
the
task/54459-investigate-queries-and-filters-to-display-the-project-list-in-projects-attribute-settings-view
branch
from
May 6, 2024 13:10
2bd405c
to
96ac329
Compare
…ibute projects table
…he-project-list-in-projects-attribute-settings-view' into task/54456-develop-a-strategy-on-how-to-reuse-the-current-project-list-implementation
Co-authored-by: Pavel Balashou <p.balashou@openproject.com>
akabiru
force-pushed
the
task/54456-develop-a-strategy-on-how-to-reuse-the-current-project-list-implementation
branch
from
May 14, 2024 15:14
0a91220
to
f9fd551
Compare
Base automatically changed from
task/54459-investigate-queries-and-filters-to-display-the-project-list-in-projects-attribute-settings-view
to
dev
May 15, 2024 11:47
…-the-current-project-list-implementation
akabiru
changed the title
[Op#54456] develop a strategy on how to reuse the current project list implementation
[Op#54456] Display the mapped projects list in the project attributes detail view
May 16, 2024
…-the-current-project-list-implementation
apfohl
approved these changes
May 21, 2024
akabiru
deleted the
task/54456-develop-a-strategy-on-how-to-reuse-the-current-project-list-implementation
branch
May 21, 2024 13:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/54456
Implementation
available_project_attributes
projects query filter to retrieve projects that have a given custom field activated [#54459] AddAvailableProjectAttributesFilter
to project queries to display the mapped projects list in projects attribute settings view #15400Projects::{TableComponent,RowComponent}
specialise to current requirements; the project list doesn't need to be full fledged.On delete last item, show no resultsSeparate WP(https://community.openproject.org/wp/55123)On delete within nested pagination, retain current pagination stateLazy load the project lists tab, only load list on click. Turbo should help out here https://turbo.hotwired.dev/reference/frames#lazy-loaded-frame@dominic-braeunlein to confirm on whether to use url or query strings to enable url sharingPageHeader
? (https://community.openproject.org/wp/55079)Cover on delete failure edge case, render Primer::Flash with error detail?(https://community.openproject.org/projects/openproject/work_packages/55133/activity)Fix HierarchySeparate WP (https://community.openproject.org/projects/openproject/work_packages/55124)Dev Notes
🚧
An empty list is returned at present even though resolving the query locally returns results.I haven't dug into why this is happening yetproject-mappings.mp4