Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better template ID tracking for team planner #10250

Merged
merged 1 commit into from Mar 7, 2022

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Mar 2, 2022

Replaces the team planner ID tracking to match what is suggested in fullcalendar/fullcalendar-angular#204 (comment)

@Reviewer: Please double check the drag behavior when adding or removing items to the views. It appeared to work fine, but a second set of eyes is certainly needed here 馃檱

Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any issue. Maybe @b12f can also have a look to double check.

@oliverguenther
Copy link
Member Author

I think this is safe to merge, if we find issues on edge, we can still easily revert

@oliverguenther oliverguenther merged commit 40f51a9 into dev Mar 7, 2022
@oliverguenther oliverguenther deleted the better-template-id-tracking branch March 7, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants