-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BundleDeployment: add and implement required serviceAccountName and installNamespace fields #857
base: main
Are you sure you want to change the base?
Conversation
35a39b9
to
7df807d
Compare
7df807d
to
d196f7b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 37.28% 35.89% -1.39%
==========================================
Files 9 8 -1
Lines 853 808 -45
==========================================
- Hits 318 290 -28
+ Misses 491 478 -13
+ Partials 44 40 -4 ☔ View full report in Codecov by Sentry. |
d196f7b
to
31cb009
Compare
…nstallNamespace fields
31cb009
to
121035b
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the |
Hacking a bit on rukpak BundleDeployment to put the following new required fields in the spec:
In the reconciler, I've removed all cluster-admin-like permissions and replaced them with just permission to create token requests.
I've also reorganized helm-operator-plugins a bit:
Lastly, I've added a token getter/cache implementation and updated the setup of the controllers in rukpak's main.go files to use that for the actionConfigGetter configuration.
With all of that, I've run a few tests with permissions missing and with all permissions present, and things seem to work.
This is a WIP because nothing in helm-operator-plugins is merged, and I've pinned to my local copy that combines both of the above PRs.