Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BundleDeployment: add and implement required serviceAccountName and installNamespace fields #857

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joelanford
Copy link
Member

Hacking a bit on rukpak BundleDeployment to put the following new required fields in the spec:

  • installNamespace
  • serviceAccountName

In the reconciler, I've removed all cluster-admin-like permissions and replaced them with just permission to create token requests.

I've also reorganized helm-operator-plugins a bit:

Lastly, I've added a token getter/cache implementation and updated the setup of the controllers in rukpak's main.go files to use that for the actionConfigGetter configuration.

With all of that, I've run a few tests with permissions missing and with all permissions present, and things seem to work.

This is a WIP because nothing in helm-operator-plugins is merged, and I've pinned to my local copy that combines both of the above PRs.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 35.89%. Comparing base (3d1ba69) to head (121035b).
Report is 34 commits behind head on main.

Files Patch % Lines
...l/controllers/bundledeployment/bundledeployment.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   37.28%   35.89%   -1.39%     
==========================================
  Files           9        8       -1     
  Lines         853      808      -45     
==========================================
- Hits          318      290      -28     
+ Misses        491      478      -13     
+ Partials       44       40       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Jun 2, 2024

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants