(actions): bump go version for go e2e tests #5841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
changed the title
everettraven
changed the title
|
/hold |
everettraven
added
release-blocker
openshift-ci
bot
added
the
do-not-merge/hold
| @@ -0,0 +1,18 @@ | |||
| # entries is a list of entries to include in | |||
There was a problem hiding this comment.
Why do we need a changelog?
How do bump the ci tests affect who uses the SDK CLI tool?
There was a problem hiding this comment.
Good point. I think I added it without thinking, will remove it. However this PR may get closed and this step be done as part of #5843
|
Closing as obsolete. Tests and testdata will be updated as a part of #5843 |
everettraven
removed
release-blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Make Go e2e tests run with Go version 1.18
Motivation for the change:
As part of the Kubebuilder bump to support k8s 1.24, Go 1.18 is now used when scaffolding a project with the go/v3 plugin. We need to adjust our e2e tests/actions to accommodate this change in the scaffolding.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs