Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update installation.md go version #5720

Merged
merged 1 commit into from
May 13, 2022

Conversation

oneto1
Copy link
Contributor

@oneto1 oneto1 commented May 1, 2022

go1.16 not work for go-quickstart anymore ,must update to go1.17

When i try to run operator-sdk init --domain example.com --repo github.com/example/memcached-operator ,failed at go1.16 and go1.18 ,only work at go1.17

Run error some as kubernetes-sigs/controller-tools#643

Description of the change:
update installation.md go version

go1.16 not work for [go-quickstart](https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/) anymore ,must update to go1.17

Signed-off-by: cc <644739768@qq.com>
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This is for the sdk binary. From the plugins side, (just to make sure) we have a validation check in kubebuilder to validate the Go version. If @camilamacedo86 / @ryantking / @rashmigottipati could please confirm if that's updated, that would be really helpful to make sure we are not confusing users.

@everettraven everettraven linked an issue May 9, 2022 that may be closed by this pull request
@jmrodri jmrodri merged commit cc7e087 into operator-framework:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation Guide - go version 1.16 vs 1.17
4 participants