-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new optional for bundle validate #4693
add new optional for bundle validate #4693
Conversation
406af1a
to
d74ebe3
Compare
I'm not sure I see the value in supplying an optional value. Shouldn't the CSV validator easily be able to perform some checks if a CSV value is present, and skip them if not present? |
f767e06
to
2f16a16
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2f16a16
to
5c56dc6
Compare
...ta/ansible/memcached-operator/bundle/manifests/memcached-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
5c56dc6
to
c35a692
Compare
This comment has been minimized.
This comment has been minimized.
c35a692
to
aacccb4
Compare
a2b5874
to
d0b1cad
Compare
d0b1cad
to
bd07ac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Before this goes in, I would really like to see docs about how this value is used in the api repo, and have them referenced in SDK docs. Otherwise we're just adding some nebulous, obscure feature. /hold |
/hold totally agree with Eric's points |
This comment has been minimized.
This comment has been minimized.
bd07ac5
to
f65e22f
Compare
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
559eb9c
to
05861b1
Compare
```sh | ||
operator-sdk bundle validate ./bundle --select-optional suite=operatorframework --optional-values=k8s-version=1.22 | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estroz @jmrodri @fabianvf @marc-obrien I added a note here as well.
Hi @estroz, @jmrodri, @fabianvf;
Please, let me know if has anything else that we ought to address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Motivation for the change:
Allow SDK to use the new checks added for OperatorHub.io
NOTE This PR is using my fork. We need to get merged first: operator-framework/api#103 and follow-up: operator-framework/api#111
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs