cleanup: remove cluster provisioning from e2e binary #3254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Previously, the e2e test suite would programatically provision a kind cluster and helm install olm on it. This allowed the e2e test suite, which is not stable when executed in parallel against a single cluster, to be executable in parallel (because each test worker would get their own cluster).
Removing the cluster provisioning code has meant that, to keep the parallel execution time gains when executing the e2es, I've had to keep the same strategy of 1 cluster / test node. Therefore, this PR also:
kubeconfig-root
flag to e2e_test: the directory where the test runners can find the kubeconfig for their clusterkind
to tools.goMotivation for the change:
The e2e tests shouldn't care about provisioning their own clusters, etc. They should just be given a kubeconfig and a running cluster.
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue