Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Helper script for a podman kind cluster with an image registry #863

Merged

Conversation

itroyano
Copy link
Contributor

Description

Adding a helper script for a podman-based kind cluster with an image registry.
This should help local testing by speeding up initial setup, required for running Tilt.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@itroyano itroyano requested a review from a team as a code owner May 16, 2024 14:33
Copy link

netlify bot commented May 16, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 508718e
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/664e02efc2dc7a000896be81
😎 Deploy Preview https://deploy-preview-863--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentito
Copy link
Contributor

bentito commented May 16, 2024

Maybe it's time to create a dev dir or put this hack? Just I think the main dir is getting pretty crowded with single files.

@bentito
Copy link
Contributor

bentito commented May 16, 2024

Other than where to put it, script lgtm

@itroyano
Copy link
Contributor Author

Agree @bentito. I'll also add a md file in there now.

@bentito
Copy link
Contributor

bentito commented May 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@itroyano
Copy link
Contributor Author

@bentito added a couple changes -

  1. dev folder
  2. the gist as a readme md

@bentito
Copy link
Contributor

bentito commented May 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one "real" thing for the readme.

dev/podman/setup-local-env-podman.md Outdated Show resolved Hide resolved
dev/podman/setup-local-env-podman.md Outdated Show resolved Hide resolved
dev/podman/setup-local-env-podman.md Outdated Show resolved Hide resolved
dev/podman/setup-local-env-podman.md Outdated Show resolved Hide resolved
dev/podman/kind-with-registry-podman.sh Show resolved Hide resolved
dev/podman/kind-with-registry-podman.sh Outdated Show resolved Hide resolved
…registry

Signed-off-by: Igor Troyanovsky <itroyano@redhat.com>
@itroyano itroyano requested a review from tmshort May 22, 2024 14:39
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@joelanford joelanford enabled auto-merge May 22, 2024 16:34
@joelanford joelanford added this pull request to the merge queue May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (0db4b93) to head (508718e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #863   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files          15       15           
  Lines         874      874           
=======================================
  Hits          727      727           
  Misses        102      102           
  Partials       45       45           
Flag Coverage Δ
e2e 62.24% <ø> (ø)
unit 74.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into operator-framework:main with commit 1f08dc3 May 22, 2024
16 checks passed
@itroyano itroyano deleted the kind-with-registry-helper branch May 22, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants