Create and set timeouts globally via a flag #43
Conversation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
global-timeout
branch
from
fb120b4
to
ad7d56b
Compare
| cfg.BindFlags(flags) | ||
| flags.DurationVar(&timeout, "timeout", 1*time.Minute, "The amount of time to wait before giving up on an operation.") |
There was a problem hiding this comment.
I like how by default this is equal to the same amount of time we now retry installplans. So there's some consistency in OLM behavior across projects. cc @benluddy
| @@ -47,3 +68,10 @@ operators from the installed catalogs.`, | |||
|
|
|||
| return cmd | |||
| } | |||
|
|
|||
| func setContext(cmd *cobra.Command, ctx context.Context) { //nolint:golint | |||
There was a problem hiding this comment.
Looks funny, but this is the only way to set the unexported field I guess.
One thing worth noting is mentioned in spf13/cobra#1118 (comment) where this root command context would be propagated down to all children. This is what we want via this PR obviously, and if the user wanted to change it on a per-invocation basis they can set the --timeout flag on the CLI to whatever. This change would also encourage to build smaller command surfaces that can be used independently of others.
so a kubectl operator <command> --timeout 5m | kubectl operator <command> --timeout 10m could be appropriate in certain cases
Signed-off-by: Joe Lanford joe.lanford@gmail.com