New Reconciler Extensions (based on context.Context information passing) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors with customized reconciliation workflows. Shows how pre/post hooks can be implemented in terms of extensions. Signed-off-by: Moritz Clasmeier <moritz@stackrox.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
| // WithExtension is an Option that registers an extension into the reconciler. | ||
| // For example, extensions may be necessary when need arises to manage certain | ||
| // resources outsides of the standard Helm-based workflow. | ||
| func WithExtension(e extension.ReconcilerExtension) Option { |
There was a problem hiding this comment.
The same suggestion as here for the design of extensions and NoOpReconcilerExtension
openshift-ci
bot
added
the
needs-rebase
|
@mtesseract: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comparison, this is essentially the same as #157 with the information passing being implemented on top of
context.Context.I tend to lean towards the way it is being done in #157, but since we had discussed it this way, I am opening this draft PR as well.
@varshaprasad96 @joelanford @misberner