Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add CatalogD doc site #202

Closed
wants to merge 1 commit into from
Closed

Conversation

anik120
Copy link
Collaborator

@anik120 anik120 commented Oct 26, 2023

No description provided.

@anik120 anik120 requested a review from a team as a code owner October 26, 2023 18:48
@ncdc ncdc changed the title CatalogD doc site Add CatalogD doc site Oct 26, 2023
. $(VENV)/activate; \
mkdocs gh-deploy --force

include Makefile.venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set your editor to add a newline at EOF - thanks 😄

name: "material"

repo_url: https://github.com/operator-framework/catalogd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e078853) 39.70% compared to head (fb08f81) 39.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   39.70%   39.70%           
=======================================
  Files           8        8           
  Lines         471      471           
=======================================
  Hits          187      187           
  Misses        265      265           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford
Copy link
Member

Is it really worth maintaining the bits required to publish a full-fledged website for catalogd standalone?

Would it suffice to have catalogd maintainers just store markdown files in a docs directory?

@everettraven
Copy link
Collaborator

Would it suffice to have catalogd maintainers just store markdown files in a docs directory?

Docs directory is reasonable to me. Another alternative is the native GitHub Wiki tab - I've seen that used for documentation for projects

@joelanford
Copy link
Member

Another alternative is the native GitHub Wiki tab

Do you know if that content committed to the repo and present in git clones? That's a hard requirement, IMO.

@everettraven
Copy link
Collaborator

everettraven commented Oct 26, 2023

Another alternative is the native GitHub Wiki tab

Do you know if that content committed to the repo and present in git clones? That's a hard requirement, IMO.

I don't think so. +1 in general to it needing to be committed content though

@ncdc ncdc changed the title Add CatalogD doc site 📖 Add CatalogD doc site Nov 1, 2023
@anik120
Copy link
Collaborator Author

anik120 commented Nov 7, 2023

Is it really worth maintaining the bits required to publish a full-fledged website for catalogd standalone?

Would it suffice to have catalogd maintainers just store markdown files in a docs directory?

@joelanford this PR is based off of the roadmap we've had for a while, in which we discussed catalogd supporting content from various types of sources. We'd discussed having a website that contains details about interaction with different types of sources via catalogd, so that the operator-controller can say "here's an example of a Catalog that sources content from an image registry, for examples and details on how to use ___, ____ and ____ source types, please see ".

I was also thinking this website will host the content for catalog authors in v1. Essentially the content will be divided into two top level sections, "For catalog authors" and "For catalog consumers". "For catalog authors" section is where we'll bring over fbc content/document opm etc for v1.

Are we thinking something different than the roadmap I mentioned above? (I haven't had the chance to catch up on the meeting with Carvel folks yet, or review any of the docs). I.e is there any new information that we should be aware of that changes the answer to your question from "yes it's worth it maintaining a website" to "no it's not"?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@everettraven
Copy link
Collaborator

Going to close this PR for now as it has been sitting for a while. We can come back and re-open this PR if we decide to continue down this route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants