Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: bring go back to v1.21 and remove a commit with a bad commit message #323

Closed

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 6, 2024

reverts 2 commits:

  • the one that bumps k8s to 1.30 and go 1.22 (I will submit another bumping to 1.30)
  • one with an erroneous duplicate message (I will resubmit with a proper message)

@openshift-ci openshift-ci bot requested review from ankitathomas and exdx May 6, 2024 13:58
Copy link

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.45%. Comparing base (7d638a0) to head (6d4c81b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   39.43%   42.45%   +3.02%     
==========================================
  Files          56       42      -14     
  Lines        4516     4011     -505     
==========================================
- Hits         1781     1703      -78     
+ Misses       2581     2156     -425     
+ Partials      154      152       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant