Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules to support k8s v0.29.2 #313

Closed

Conversation

OchiengEd
Copy link
Contributor

Add support for kubernetes v0.29.2 in the Operator Framework/api project dependencies.

Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OchiengEd
Once this PR has been reviewed and has the lgtm label, please assign jmrodri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.45%. Comparing base (4454fc8) to head (43d2876).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files          42       42           
  Lines        4011     4011           
=======================================
  Hits         1703     1703           
  Misses       2156     2156           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neo2308
Copy link
Contributor

Neo2308 commented Feb 22, 2024

@OchiengEd it seems there changes may be required in a couple of more files, could you refer to a similar PR from before: https://github.com/operator-framework/api/pull/292/files#diff-75ef0ffb5d877865f116117605304acde0046b6fd17cd1014376d020d39c4a17

go.mod Outdated Show resolved Hide resolved
@OchiengEd OchiengEd marked this pull request as draft March 1, 2024 16:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@OchiengEd OchiengEd closed this Mar 6, 2024
@OchiengEd OchiengEd reopened this Mar 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2024
OchiengEd and others added 4 commits March 18, 2024 14:49
Add support for kubernetes v0.29.2 in the Operator Framework api project
dependencies.

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Updated controller tools to v0.14.0.
Refreshed auto-generated files.
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@OchiengEd OchiengEd closed this Mar 18, 2024
@OchiengEd OchiengEd deleted the add_k8s_v0.29.2 branch March 18, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants