Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes codecov-action optional #287

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jul 28, 2023

We do not want to fail the job if codecov fails
to upload the report due to rate limiting.

We do not want to fail the job if codecov fails
to upload the report due to rate limiting.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot requested review from awgreene and oceanc80 July 28, 2023 15:15
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: m1kola
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #287 (fe2cfa3) into master (fdfcb35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   41.94%   41.94%           
=======================================
  Files          39       39           
  Lines        3488     3488           
=======================================
  Hits         1463     1463           
  Misses       1879     1879           
  Partials      146      146           

@ncdc ncdc merged commit 92e4341 into operator-framework:master Jul 28, 2023
5 checks passed
@m1kola m1kola deleted the codecov_do-not-fail-please branch July 28, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants