Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restores openapi-gen tag for APIResourceReference #283

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Restores openapi-gen tag for APIResourceReference #283

merged 1 commit into from
Apr 25, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Apr 25, 2023 •
edited

It looks like it was accidentally removed in #168.

Now when we update github.com/operator-framework/api package for OLM, packageserver fails with the following error:

unable to get openapi models: cannot find model definition for github.com/operator-framework/api/pkg/operators/v1alpha1.APIResourceReference. If you added a new type, you may need to add +k8s:openapi-gen=true to the package or type and run code-gen again

@m1kola
Restores openapi-gen tag for APIResourceReference
d8382bb 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@m1kola m1kola marked this pull request as ready for review April 25, 2023 11:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
ankitathomas
ankitathomas approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
everettraven
everettraven approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 047ab0b into operator-framework:master Apr 25, 2023
4 checks passed
@m1kola m1kola deleted the fix_openapi_codegen branch April 25, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas ankitathomas approved these changes

@everettraven everettraven everettraven approved these changes

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@ankitathomas ankitathomas

@everettraven everettraven

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m1kola @grokspawn @ankitathomas @everettraven @openshift-merge-robot