Add API for cleanup spec and status #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the operand cleanup API that allows configuring the CSV to enable cleanup of CRs managed by this CSV's operator when the CSV is deleted. This also includes a status.cleanup block that will be used to show the progress of cleanup.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
5 tasks
hasbro17
commented
Mar 4, 2021
|
/hold Should be okay to review but we might have to make adjustments depending on the implementation at operator-framework/operator-lifecycle-manager#2030 |
openshift-ci-robot
added
the
do-not-merge/hold
hasbro17
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
feat: fixup cleanup api
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the operand cleanup API that allows configuring the CSV to enable cleanup of CRs managed by this CSV's operator when the CSV is deleted.
This also includes a status.cleanup block that will be used to show the progress of cleanup.
Enhancement: https://github.com/operator-framework/enhancements/blob/master/enhancements/olm-deletes-operands.md
RFE: operator-framework/operator-lifecycle-manager#1787
TODO: