-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ziti edge service helper #1712
Open
gberl002
wants to merge
19
commits into
release-next
Choose a base branch
from
ziti-edge-service-helper
base: release-next
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ziti edge service helper #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
closes #1663 Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
…hare code Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
…review. Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
dovholuknf
reviewed
Feb 28, 2024
@@ -383,3 +384,18 @@ func waitForController(ctrlUrl string, done chan struct{}) { | |||
} | |||
done <- struct{}{} | |||
} | |||
|
|||
func IsPortListening(host string, port int, timeout time.Duration) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function doesn't seem to be used?
Changing endpoint to intercept address Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
qrkourier
requested changes
Feb 29, 2024
ziti/cmd/edge/secure.go
Outdated
} | ||
|
||
// Create a dial config | ||
interceptAddress := svcName + ".ziti" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
interceptAddress := svcName + ".ziti" | |
interceptAddress := svcName + ".internal" |
Provided an output summary with attribute and intercept details Signed-off-by: gberl002 <geoff.berl@netfoundry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the configs, service, and service policies for an endpoint using one cli command.
Example usages
Create dial and bind setup for
localhost:1280
usingtcp
, the service is calledmyservice
, with an endpoint atmyservice.ziti
(defaulted to servicename.ziti)ziti edge secure myservice tcp:localhost:1280
Create dial and bind setup for
localhost:1280
using tcp, the service is calledmyervice
, with a custom endpoint atmyendpoint.ziti
ziti edge secure myservice tcp:localhost:1280 --endpoint myendpoint.ziti
Create dial and bind setup for
127.0.0.1:1280
using "tcp,udp" protocols, the service is calledmyservice
, with an endpoint atmyservice.ziti
. When not provided, allowed protocols defaults to bothtcp
andudp
, and the assumed address is127.0.0.1
. At a minimum, port must always be provided.ziti edge secure myservice 1280