New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django packages: convert to python packaging format + add python3 variant #9400
Conversation
@jefferyto gave me some hints for pillow ( #8715 (comment)) and I haven't been able look at it until now. As I don't want to block this PR, I will apply changes from @jefferyto and test it. |
oh right; |
I have one suggestion for grouping the django packages under their own submenu: Note that there's no need to worry about compilation of unnecessary packages, because The result is this:
And then this in the next screen:
There are two side-effects: (1) we lose two characters in the title of each django-* package, because of the indentation; (2) django will have to be selected to build the dependent I don't intend this to be done here, but since we already have a backlog of PRs with changes to these packages, I might as well describe mine 😄, and see where I can stand in line. |
given the amount of duplicated/repetitive code, some grouping makes sense |
Changelog v1 -> v2:
this was the only thing that seemed to me, that had a clear conclusion/change associated; |
Changelog v2 -> v3:
|
Would you please rebase your PR against master to resolve conflicts, which I did as I merged pillow and qrcode? I will appreciate if you can keep the bump of PKG_RELEASE for qrcode together with change of email address. |
sure |
It's fine as I did it a few minutes ago. :) |
oh; |
The email change was part of a previous request from a different PR series. In this series, the change is the only thing left to do (from what the original changeset intended to do). Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
The pillow package has been updated to the Python[3] packaging format, and now the package names are `python-pillow` & `python3-pillow`. This change updates seafile-seahub to use it. Not updating other packages as they will be converted to Python[3] packaging format. And not bumping PKG_RELEASE here as it will be done in the last commit that updates deps for seafile-seahub. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
This change also updates the maintainer email to cotequeiroz@gmail.com, as requested on a different change. Not updating deps here, since that will be done in the next changeset that will convert packages to the Python[3] packaging format. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
This change also updates the maintainer email to cotequeiroz@gmail.com, as requested on a different change. Also, changing here is the download URL to github's codeload, since that one offers .tar.gz archives. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
This change also updates the maintainer email to cotequeiroz@gmail.com, as requested on a different change. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
1377e9d
to
8c96971
Compare
Changelog v3 -> v4:
|
Maintainer: me, @cotequeiroz
Compile tested: openwrt/openwrt@917eeaf x86
Run tested: openwrt/openwrt@917eeaf x86
This is the last of the series for django packages.
Not doing any updates now. This will be in a later series.
Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com