rust: fix remote filesystem issue #24146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you :) |
|
Just update the version that got reviewed since between one and another review an error slipped in. |
|
Please retake the commit now that landed. Thank you |
|
@lu-zero thanks for your work. If CI/CD is happy I will merge this. |
If the download directory is on another filesystem (NFS), then the current implementation of bootstrapping rust fails. Because the 'syscall' (rename) does not work on crossing filesystem boundary. This chnage was already merged upstream to the github main rust repository. rust-lang/rust#124975 The patch has been rebased so that it can be applied correctly. No functional change. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @1715173329 @lu-zero
Compile tested: x86_64, -, OpenWrt latest
Run tested: x86_64, -, OpenWrt latest, tests done
Description:
If the download directory is on another filesystem (NFS), then the current implementation of bootstrapping rust fails. Because the
syscall(rename) does not work on crossing filesystem boundary.This patch has already been merged upstream.
rust-lang/rust#124975