Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce .gitignore #24057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce .gitignore #24057

wants to merge 1 commit into from

Conversation

BKPepe
Copy link
Member

@BKPepe BKPepe commented May 1, 2024

This PR adds file .gitignore to this repository.

@Ansuel
Copy link
Member

Ansuel commented May 1, 2024

maybe also .patch in the root directory?

@mhei
Copy link
Member

mhei commented May 1, 2024

I'm a little bit unsure, whether this is really required. Just for reference:
https://blog.martinhujer.cz/dont-put-idea-vscode-directories-to-projects-gitignore/

@BKPepe
Copy link
Member Author

BKPepe commented May 1, 2024

maybe also .patch in the root directory?

I'm a little bit unsure, whether this is really required. Just for reference: https://blog.martinhujer.cz/dont-put-idea-vscode-directories-to-projects-gitignore/

Well, the headline could be somehow true, I am not saying that it is wrong, but even there is some discussion in comments below the article Anyway, .vscode is also included in OpenWrt main repository. It was added by openwrt/openwrt@3c3a96d.

Also, it was requested to have .gitignore with .DS_Store in this comment: #23976 (comment)

@BKPepe BKPepe marked this pull request as ready for review May 1, 2024 16:18
@mhei
Copy link
Member

mhei commented May 1, 2024

Yes, this is a controversial topic. There are arguments for and against. Personally, I don't think it's necessary, but I'm not totally against it either.

.gitignore Outdated Show resolved Hide resolved
@Ansuel
Copy link
Member

Ansuel commented May 2, 2024

@mhei my 2 cent are that .vscode might be handy for single project repository where it would be beneficial to have vscode or editors in general setup for the project.

For this specific case where these are a sum of many Makefile and project... I can't find a way where .vscode would be beneficial... With all the variety of code and style we have I think there isn't a common option for everyone.

This file specifies files that Git should ignore while creating
commit.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Copy link
Member

@mhei mhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants