Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chores] Centralized ProtectedApiMixin logic #280 #329

Closed
wants to merge 1 commit into from
Closed

[chores] Centralized ProtectedApiMixin logic #280 #329

wants to merge 1 commit into from

Conversation

Aryamanz29
Copy link
Member

@Aryamanz29 Aryamanz29 self-assigned this Dec 12, 2022
@Aryamanz29 Aryamanz29 force-pushed the issue-280/centralize-protectedapimixin-logic branch 2 times, most recently from 4fe60fb to 96ba22b Compare December 12, 2022 19:35
@coveralls
Copy link

coveralls commented Dec 12, 2022 •
edited

Coverage Status

Coverage remained the same at 98.656% when pulling c781678 on issue-280/centralize-protectedapimixin-logic into bf1d7d7 on master.

@Aryamanz29 Aryamanz29 force-pushed the issue-280/centralize-protectedapimixin-logic branch 2 times, most recently from 572d466 to 5bcf081 Compare December 12, 2022 19:52
@Aryamanz29 Aryamanz29 mentioned this pull request Dec 12, 2022
Merged
@Aryamanz29 Aryamanz29 force-pushed the issue-280/centralize-protectedapimixin-logic branch 2 times, most recently from 38628f6 to c3a44b3 Compare December 12, 2022 20:28
@Aryamanz29 Aryamanz29 force-pushed the issue-280/centralize-protectedapimixin-logic branch from c3a44b3 to c781678 Compare December 12, 2022 20:31
@Aryamanz29 Aryamanz29 marked this pull request as ready for review December 12, 2022 20:55
@Aryamanz29 Aryamanz29 force-pushed the issue-280/centralize-protectedapimixin-logic branch from ab84bb2 to c781678 Compare December 12, 2022 21:15
@nemesifier
Copy link
Member

Sorry I realized I was wrong to open this here, I am transferring the issue to openwisp-users, please reopen there but make sure to include a basic test.

@nemesifier nemesifier closed this Dec 13, 2022
@Aryamanz29 Aryamanz29 deleted the issue-280/centralize-protectedapimixin-logic branch December 13, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier Awaiting requested review from nemesifier

Assignees

@Aryamanz29 Aryamanz29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Centralize ProtectedApiMixin logic
3 participants
@Aryamanz29 @coveralls @nemesifier