Skip to content

Commit

Permalink
get rid of browniebroke/read-nvmrc-action, since `actions/setup-nod…
Browse files Browse the repository at this point in the history
…e` can read node version from `.nvmrc` file directly

cf actions/setup-node#32 (comment)
  • Loading branch information
adrienjoly committed Dec 27, 2022
1 parent 882ab60 commit bb24ffe
Showing 1 changed file with 8 additions and 24 deletions.
32 changes: 8 additions & 24 deletions .github/workflows/ci.yml
Expand Up @@ -19,11 +19,9 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- name: npm install
env:
Expand Down Expand Up @@ -69,11 +67,9 @@ jobs:
- 27017:27017
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- uses: c-py/action-dotenv-to-setenv@v2
with:
Expand Down Expand Up @@ -128,11 +124,9 @@ jobs:
- 27117:27017
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- uses: c-py/action-dotenv-to-setenv@v2
with:
Expand All @@ -151,11 +145,9 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- name: npm install
env:
Expand All @@ -173,11 +165,9 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- name: npm install
env:
Expand All @@ -200,11 +190,9 @@ jobs:
- 27017:27017
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- uses: c-py/action-dotenv-to-setenv@v2
with:
Expand Down Expand Up @@ -238,11 +226,9 @@ jobs:
- 27117:27017
steps:
- uses: actions/checkout@v3
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- uses: c-py/action-dotenv-to-setenv@v2
with:
Expand Down Expand Up @@ -387,11 +373,9 @@ jobs:
with:
# to prevent "You're not authorized to push to this branch"
persist-credentials: false
- uses: browniebroke/read-nvmrc-action@v1 # Read node version from `.nvmrc` file
id: nvmrc
- uses: actions/setup-node@v3
with:
node-version: '${{ steps.nvmrc.outputs.node_version }}'
node-version-file: '.nvmrc'
cache: 'npm'
- run: npm install --prefer-offline --no-audit
if: github.event_name == 'push'
Expand Down

0 comments on commit bb24ffe

Please sign in to comment.