[OV JS] Remove acceptable_types parameter from js_to_cpp() template function #24459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into almilosz/js-to-cpp
vishniakov-nikolai
approved these changes
May 15, 2024
Comment on lines
+80
to
82
| } else { | ||
| OPENVINO_THROW("Passed argument must be of type Array or TypedArray."); | ||
| } |
There was a problem hiding this comment.
If else is last instruction in the function body we can white it out of condition
Suggested change
| } else { | |
| OPENVINO_THROW("Passed argument must be of type Array or TypedArray."); | |
| } | |
| } | |
| OPENVINO_THROW("Passed argument must be of type Array or TypedArray."); |
There was a problem hiding this comment.
I would like to keep it for the sake of readability
| @@ -184,7 +145,7 @@ ov::preprocess::ResizeAlgorithm js_to_cpp<ov::preprocess::ResizeAlgorithm>( | |||
| } else if (algorithm == "RESIZE_LINEAR") { | |||
| return ov::preprocess::ResizeAlgorithm::RESIZE_LINEAR; | |||
| } else { | |||
| OPENVINO_THROW(std::string("Not supported resizeAlgorithm.")); | |||
| OPENVINO_THROW("Not supported resizeAlgorithm."); | |||
There was a problem hiding this comment.
Possible to release from brackets
src/bindings/js/node/src/helper.cpp
Outdated
| if (!acceptableType(elem, acceptable_types)) { | ||
| OPENVINO_THROW(std::string("Cannot convert Napi::Value to std::map<std::string, ov::Any>")); | ||
| } | ||
| OPENVINO_ASSERT(elem.IsObject(), "Cannot convert Napi::Value to std::map<std::string, ov::Any>"); |
There was a problem hiding this comment.
Element at index idx should be an Object type
…into almilosz/js-to-cpp
vishniakov-nikolai
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
const std::vector<napi_types>& acceptable_typesparam from templateTargetType js_to_cpp(const Napi::Value&, const std::vector<napi_types>& acceptable_types);int32_t js_to_cpp<int32_t>(const Napi::CallbackInfo& info, const size_t idx, const std::vector<napi_types>& acceptable_types);Tickets: