Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with inlined inputs #24448

Merged
merged 11 commits into from May 22, 2024
Merged

Fixed bug with inlined inputs #24448

merged 11 commits into from May 22, 2024

Conversation

suryasidd
Copy link
Contributor

@suryasidd suryasidd commented May 9, 2024 •
edited

Details:

  • Fixed bug with inlined inputs for fx decoder which were being added as parameters and are not needed.

Tickets:

@suryasidd suryasidd requested a review from a team as a code owner May 9, 2024 13:45
@github-actions github-actions bot added category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend labels May 9, 2024
@ilya-lavrenov ilya-lavrenov added the pr: needs tests PR needs tests updating label May 9, 2024
mvafin
mvafin reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add test

@mvafin
Copy link
Contributor

mvafin commented May 10, 2024

Also please check why torch.compile tests fail for arange

@suryasidd suryasidd requested review from a team as code owners May 20, 2024 15:54
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label May 20, 2024
@github-actions github-actions bot removed the category: Python API OpenVINO Python bindings label May 20, 2024
@suryasidd suryasidd modified the milestones: 2022.3, 2024.2 May 20, 2024
@moslex moslex added the priority: high High piority label May 21, 2024
@suryasidd
Copy link
Contributor Author

build_jenkins

@suryasidd suryasidd added this pull request to the merge queue May 22, 2024
Merged via the queue into openvinotoolkit:master with commit e7c60bb May 22, 2024
117 checks passed
@suryasidd suryasidd deleted the surya/fx_inlined_inputs branch May 22, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@mvafin mvafin mvafin approved these changes

@rkazants rkazants rkazants left review comments

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees

@mvafin mvafin

Labels
category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend Code Freeze pr: needs tests PR needs tests updating priority: high High piority
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suryasidd @mvafin @ilya-lavrenov @rkazants @moslex