Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[intel-npu] Implementing DEVICE_GOPS metric #24439

Merged
merged 2 commits into from May 13, 2024
Merged

[intel-npu] Implementing DEVICE_GOPS metric #24439

merged 2 commits into from May 13, 2024

Conversation

csoka
Copy link
Contributor

@csoka csoka commented May 9, 2024 •
edited

Details:

  • Implemeting DEVICE_GOPS metric for intel-npu plugin

Tickets:

  • EISW-123380

@csoka csoka requested review from a team as code owners May 9, 2024 10:39
@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label May 9, 2024
ArtemySkrebkov
ArtemySkrebkov approved these changes May 9, 2024
View reviewed changes
src/plugins/intel_npu/src/backend/src/zero_device.cpp Outdated
device_gops[ov::element::f32] = 0;
device_gops[ov::element::u8] = gops;
device_gops[ov::element::i8] = gops;
device_gops[ov::element::f16] = 0.5f * gops;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my education, why do we multiple by 0.5 for fp16?

Copy link
Contributor Author

@csoka csoka May 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is based on the indications from the Arch team, i don't know the details unfortunately

razvanapetroaie
razvanapetroaie approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@razvanapetroaie razvanapetroaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket in description if you don't mind

@csoka
Copy link
Contributor Author

csoka commented May 9, 2024

I still need to add a cross-OS backwards compatibility check, we are currently working on getting alined-with with the driver teams, as older drivers don't report perf/slice in physicalEUSimdWidth, leading to incorrect numbers.

@csoka csoka force-pushed the npu_gops branch 2 times, most recently from c8fbf89 to 7582072 Compare May 12, 2024 10:29
@PatrikStepan PatrikStepan added this pull request to the merge queue May 13, 2024
Merged via the queue into openvinotoolkit:master with commit 2fc628a May 13, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtemySkrebkov ArtemySkrebkov ArtemySkrebkov approved these changes

@razvanapetroaie razvanapetroaie razvanapetroaie approved these changes

Assignees
No one assigned
Labels
category: NPU OpenVINO NPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csoka @ArtemySkrebkov @razvanapetroaie @PatrikStepan