Skip to content

Commit

Permalink
Fixes broken images for the checkboxes (#221)
Browse files Browse the repository at this point in the history
# AtlasKit
- Label as concept is separately proposed for the AtlasKit so I just copy from default
- Without label probably supported by AtlasKit given that label property can be set and in the documentation there no clear specification on required/not-required status of the field. If somebody from Atlassian can join and tell exact state, then it can be documented for `withoutLabel` concept
- Removed just HTML attributes like id, name, value. My understanding they are not of value for this project.

# Evergreen
- Removed just HTML attributes like id, name, value. My understanding they are not of value for this project.
- Removed `invalid`, since for them this is only ARIA related change. Since no visibility for UI, then it's not clear how to capture that in current documentation
- Removed `appearance` and `theme` since this is abstrations which are not part of this project IMO.
  • Loading branch information
kant2002 committed Nov 25, 2020
1 parent 037fbb4 commit 6ffd5dc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 38 deletions.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 4 additions & 14 deletions research/src/sources/atlassian.json5
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@
"description": "",
"image": "atlaskit-checkbox-basic.png"
},
{
"name": "id",
"description": "id assigned to input"
},
{
"name": "checked",
"description": "Sets whether the checkbox is checked or unchecked.",
Expand Down Expand Up @@ -118,19 +114,13 @@
},
{
"name": "required",
"description": "Marks the field as required & changes the label style."
"description": "Marks the field as required & changes the label style.",
"image": "atlaskit-checkbox-required.png"
},
{
"name": "label",
"description": "The label to be displayed to the right of the checkbox. The label is part of the clickable element to select the checkbox."
},
{
"name": "name",
"description": "The name of the submitted field in a checkbox."
},
{
"name": "value",
"description": "The value to be used in the checkbox input. This is the value that will be returned on form submission."
"description": "The label to be displayed to the right of the checkbox. The label is part of the clickable element to select the checkbox.",
"image": "atlaskit-checkbox-basic.png"
}
]
},
Expand Down
24 changes: 0 additions & 24 deletions research/src/sources/evergreen.json5
Original file line number Diff line number Diff line change
Expand Up @@ -164,23 +164,11 @@
"description": "Basic checkbox",
"image": "evergreen-checkbox-basic.png"
},
{
"name": "id",
"description": "The id attribute of the checkbox."
},
{
"name": "name",
"description": "The id attribute of the checkbox."
},
{
"name": "label",
"description": "Label of the checkbox.",
"image": "evergreen-checkbox-label.png"
},
{
"name": "value",
"description": "The value attribute of the checkbox."
},
{
"name": "checked",
"description": "The checked attribute of the checkbox.",
Expand All @@ -195,18 +183,6 @@
"name": "disabled",
"description": "When true, the checkbox is disabled.",
"image": "evergreen-checkbox-disabled.png"
},
{
"name": "invalid",
"description": "When true, the aria-invalid attribute is true. Used for accessibility."
},
{
"name": "appearance",
"description": "The appearance of the checkbox. The default theme only comes with a default style."
},
{
"name": "theme",
"description": "Theme provided by ThemeProvider."
}
]
},
Expand Down

0 comments on commit 6ffd5dc

Please sign in to comment.