Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH Actions versions #4542

Merged

Conversation

leonardehrenfried
Copy link
Member

Github Actions is updating their node runtime version, so you see a large number of warnings to update to Actions version. Example: https://github.com/opentripplanner/OpenTripPlanner/actions/runs/3313424495

This PR updates the Actions that will stop working in the future.

@leonardehrenfried leonardehrenfried changed the title Update outdated GH Actions versions Update GH Actions versions Oct 24, 2022
.github/workflows/cibuild.yml Outdated Show resolved Hide resolved
.github/workflows/cibuild.yml Outdated Show resolved Hide resolved
Co-authored-by: Hannes Junnila <hannes.junnila@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 59.89% // Head: 60.18% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (57bd5e2) compared to base (0b52275).
Patch coverage: 75.75% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #4542      +/-   ##
=============================================
+ Coverage      59.89%   60.18%   +0.28%     
- Complexity     11925    12087     +162     
=============================================
  Files           1557     1570      +13     
  Lines          62400    62661     +261     
  Branches        6982     7020      +38     
=============================================
+ Hits           37375    37711     +336     
+ Misses         22868    22775      -93     
- Partials        2157     2175      +18     
Impacted Files Coverage Δ
...ipplanner/ext/vectortiles/VectorTilesResource.java 8.79% <ø> (+0.92%) ⬆️
...ipplanner/standalone/server/OTPWebApplication.java 0.00% <0.00%> (ø)
...ipplanner/standalone/server/VaryRequestFilter.java 0.00% <0.00%> (ø)
...ipplanner/standalone/server/EtagRequestFilter.java 89.28% <89.28%> (ø)
...in/java/org/opentripplanner/model/UpdateError.java 80.64% <0.00%> (-15.01%) ⬇️
...lapi/datafetchers/LegacyGraphQLTicketTypeImpl.java 35.29% <0.00%> (-14.71%) ⬇️
...standalone/config/sandbox/TransmodelAPIConfig.java 71.42% <0.00%> (-8.58%) ⬇️
...opentripplanner/ext/fares/model/FareAttribute.java 57.89% <0.00%> (-5.75%) ⬇️
...ox/VehicleRentalServiceDirectoryFetcherConfig.java 90.00% <0.00%> (-5.46%) ⬇️
...ntripplanner/gtfs/mapping/FareAttributeMapper.java 95.00% <0.00%> (-5.00%) ⬇️
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hannesj
hannesj previously approved these changes Oct 25, 2022
hannesj
hannesj previously approved these changes Oct 25, 2022
@t2gran t2gran added this to the 2.2 milestone Oct 25, 2022
@optionsome
Copy link
Member

Have you validated that the cache works? At least in the latest run, it says "maven cache is not found". I think within the scope of the pr, the actions have run more than once. Shouldn't there be cache in that case?

@optionsome
Copy link
Member

Or was it that the cache was only within the scope of one actions run? I see in a later step that cache is saved but at that point, it's no longer needed for anything within the actions run.

@leonardehrenfried
Copy link
Member Author

I'm rerunning CI as I'm not sure.

@leonardehrenfried
Copy link
Member Author

To me it looks like the cache is retrieved during jdk setup and correctly used by the maven command.

Can you confirm this?

@optionsome
Copy link
Member

To me it looks like the cache is retrieved during jdk setup and correctly used by the maven command.

Can you confirm this?

Yes it looks like it used it now. I wonder why it didn't use it before. Did the last commit before this somehow affect maven?

@leonardehrenfried
Copy link
Member Author

No, but the cache is cleared after a few days. I think this is what happened here.

@leonardehrenfried leonardehrenfried merged commit 4c56ba1 into opentripplanner:dev-2.x Oct 31, 2022
@leonardehrenfried leonardehrenfried deleted the gh-actions-update branch October 31, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants