Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

RFC: Add an extension to Tracer interface for custom go context creation #220

Merged
merged 3 commits into from Sep 12, 2019
Merged

RFC: Add an extension to Tracer interface for custom go context creation #220

merged 3 commits into from Sep 12, 2019

Commits on Sep 6, 2019

  1. Add an extension interface for Tracer implementations 

    The new TracerContextWithSpanExtension interface provides a way to
hook into the ContextWithSpan function, so the implementation can put
some extra information to the context.

The opentracing to opentelemetry bridge needs the context to set the
current opentelemetry span, so the opentelemetry API in the layer
below the one using opentracing can still get the right parent span.
    @krnowak
    krnowak committed Sep 6, 2019
    Copy the full SHA
    891393b View commit details
    Browse the repository at this point in the history

  2. Call the hook in the ContextWithSpan function if possible 

    So the implementation can still affect the way the go context is set
up.
    @krnowak
    krnowak committed Sep 6, 2019
    Copy the full SHA
    c848a0f View commit details
    Browse the repository at this point in the history

  3. Add a test for the TracerContextWithSpanExtension interface

    @krnowak
    krnowak committed Sep 6, 2019
    Copy the full SHA
    60fbc08 View commit details
    Browse the repository at this point in the history