Fix captions #741
Open
Fix captions #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jintgeorge
reviewed
Apr 23, 2024
CHANGELOG.md
Outdated
|
|
||
| This version fixes some crashes. | ||
|
|
||
| This version the `OTSubscriber captionReceived` event handler. |
There was a problem hiding this comment.
captionReceived or captionsReceived. Also the line seems to be incomplete.
There was a problem hiding this comment.
It is captionReceived, like in the web client SDK. I fixed the incomplete sentence.
jintgeorge
reviewed
Apr 23, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,13 @@ | |||
| # 2.27.4 (April 2024) | |||
|
|
|||
| - [Update]: Update OpenTok Android SDK and OpenTok iOS SDK to version 2.27.1. | |||
There was a problem hiding this comment.
The previous version says Vonage Video iOS SDK and this one says Opentok SDK. Is that intentional?. Is this version update done in another PR, not seeing this version change in this PR.
jeffswartz
commented
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing checklist
Solves issue(s)