feat: add scaleBehavior for subscriber and publisher view #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-sheikh1
approved these changes
Mar 5, 2021
abdulajet
reviewed
May 27, 2021
| const sanitizeProperties = (properties) => { | ||
| if (typeof properties !== 'object') { | ||
| return { | ||
| scaleBehavior: 'fill', |
There was a problem hiding this comment.
I think having this as the default breaks it. I couldn't get it to work unless I changed this value here. I assume this is because the subscriber loads in a bit after the view is rendered?
There was a problem hiding this comment.
On which platform / or how does it break for you? 😯
There was a problem hiding this comment.
Both. The subscriber scaleBehavior is always fill
There was a problem hiding this comment.
The subscriber views, bottom one, should be fit
|
LGTM |
|
@abdulajet what do you think should be done with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing checklist
Solves issue(s)
Closes #327.
This PR introduces a new property
scaleBehavior: "fill" | "fit"for OTSubscriber and OTPublisher which translates to the OTVideoViewScaleBehavior on iOS, respectively BaseVideoRenderer.STYLE_VIDEO_* on Android.By default, the value is "fill" which will scale the video to fill the entire view, with cropping as needed. This was the only behavior available so far, thus, no code changes in present apps are required. The new value "fit" will shrink the video (pillarboxing), so that the entire video is contained in the view.