Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate location of bootstrap.min.css loading #110

Merged
merged 1 commit into from May 12, 2022
Merged

Conversation

tischrei
Copy link
Member

Due to the issue that there is no option to provide several css files in theme.conf, we need to load bootstrap.min.css in theme specific css file (in this case otcdocstheme.css) to load general layout statements first to enable us to overwrite statements without using !important or having to option to overwrite !important statements of bootstrap itself.

@tischrei tischrei requested a review from gtema May 11, 2022 10:15
@Nils-Magnus
Copy link
Member

Did a click-through test on UI level. LGTM.

@@ -1,3 +1,5 @@
@import "bootstrap.min.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@tischrei tischrei May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can, but if I do it like this. The "default.css" is over otcdocstheme.css ;-). That makes no sense as well. I have opened an issue on: sphinx-doc/sphinx#10444

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side; I do not intend to keep it like this forever. But we need to have something like this to overcome the current issue. I am trying to invest some time in docsportal again, but I need this commit, first.

@tischrei tischrei added the gate Merge PR label May 12, 2022
@otc-zuul
Copy link

otc-zuul bot commented May 12, 2022

Build succeeded.

✔️ otc-tox-docs SUCCESS in 6m 31s
✔️ otc-tox-pep8 SUCCESS in 4m 06s

@otc-zuul otc-zuul bot merged commit 859c0c9 into main May 12, 2022
@otc-zuul otc-zuul bot deleted the refactor_css branch May 12, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants