Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of DataArts Factory scripts API #656

Merged
merged 26 commits into from
May 24, 2024

Conversation

sgmv
Copy link
Contributor

@sgmv sgmv commented May 13, 2024

What this PR does / why we need it

The next changes for DataArt API. This PR brings the ability to manage DataArts Factory scripts.

Which issue this PR fixes

Special notes for your reviewer

@sgmv sgmv requested a review from artem-lifshits as a code owner May 13, 2024 08:54
@sgmv sgmv self-assigned this May 13, 2024
sgmv added 2 commits May 14, 2024 14:43
# Conflicts:
#	acceptance/openstack/dataarts/v1.1/helpers.go
#	acceptance/openstack/dataarts/v1.1/links_test.go
#	openstack/dataarts/v1.1/link/Create.go
#	openstack/dataarts/v1.1/link/Get.go
#	openstack/dataarts/v1.1/link/Update.go
#	openstack/dataarts/v1.1/link/common.go
@sgmv sgmv marked this pull request as draft May 16, 2024 10:30
@sgmv sgmv changed the title Implementation of DataArts Factory links API Implementation of DataArts Factory scripts API May 16, 2024
@sgmv sgmv marked this pull request as ready for review May 16, 2024 10:47
@anton-sidelnikov anton-sidelnikov added enhancement New feature or request gate Merge PR labels May 23, 2024
artem-lifshits
artem-lifshits previously approved these changes May 23, 2024
Copy link
Contributor

otc-zuul bot commented May 23, 2024

Build failed.
https://zuul.otc-service.com/t/eco/buildset/86ec037eda2e496cae3c77f78a395530

✔️ otc-golangci-lint SUCCESS in 2m 35s
✔️ golang-make-vet SUCCESS in 3m 04s
✔️ golang-make-test SUCCESS in 3m 32s
golang-make-functional FAILURE in 7m 31s

artem-lifshits and others added 8 commits May 24, 2024 11:34
[FGS]: trigger fixes 

What this PR does / why we need it
Fixes for TF resource (doc bug & redundant fields removed).

Reviewed-by: Anton Sidelnikov
Reviewed-by: Aloento
[FGS]: Events test

What this PR does / why we need it
Management of test events.
Acceptance tests
=== RUN   TestFunctionGraphEventsLifecycle
    events_test.go:28: Attempting to CREATE TEST EVENT
    events_test.go:49: Attempting to LIST TEST EVENTS
    events_test.go:57: Attempting to UPDATE TEST EVENT
    events_test.go:67: Attempting to GET TEST EVENT
    tools.go:72: {
          "id": "fd9942a4-71d2-471b-9bd5-c9c6eb351ee7",
          "content": "ewogICAgImJvZHkiOiAiIiwKICAgICJy",
          "last_modified": 1715772656,
          "name": "funcgraph-eventuI9D"
        }
    events_test.go:42: Attempting to DELETE TEST EVENT
--- PASS: TestFunctionGraphEventsLifecycle (2.32s)
PASS

Process finished with the exit code 0

Reviewed-by: Aloento
Reviewed-by: Anton Sidelnikov
css api was updated

What this PR does / why we need it
Which issue this PR fixes

Special notes for your reviewer
Datastore type now required for cluster,
BasePath attribute added for snapshot configuration and required
=== RUN   TestSnapshotWorkflow
    tools.go:72: {
          "keepday": 1,
          "period": "00:00 GMT+03:00",
          "prefix": "snap",
          "bucket": "snapshot-sdk-test-bucket",
          "basePath": "css_repository/css-test",
          "agency": "css_obs_agency",
          "enable": "true",
          "snapshotCmkId": ""
        }
--- PASS: TestSnapshotWorkflow (752.81s)
PASS

Debugger finished with the exit code 0

Reviewed-by: Artem Lifshits
Reviewed-by: Aloento
[CTS]: v3 API update

What this PR does / why we need it
Update API according to new params: https://docs.otc.t-systems.com/cloud-trace-service/api-ref/v3_apis_recommended/tracker_management/creating_a_tracker.html
Related to #2511
Acceptance tests
=== RUN   TestTrackersLifecycle
    helpers.go:14: Attempting to create OBS bucket
    helpers.go:27: Created OBS Bucket: obs-cts-testk6j65
    trackers_test.go:25: Attempting to create CTSv3 Tracker
    trackers_test.go:46: Created CTSv3 Tracker: system
    trackers_test.go:53: Attempting to update CTSv3 Tracker: system
    trackers_test.go:66: Updated CTSv3 Tracker: system
    trackers_test.go:39: Attempting to delete CTSv3 Tracker: system
    trackers_test.go:42: Deleted CTSv3 Tracker: system
    helpers.go:33: Attempting to delete OBS bucket: obs-cts-testk6j65
    helpers.go:54: Deleted OBS Bucket objects: [{{ } CloudTraces/ }]
    helpers.go:59: Deleted OBS Bucket: obs-cts-testk6j65
--- PASS: TestTrackersLifecycle (4.49s)
PASS

Process finished with the exit code 0

Reviewed-by: Anton Sidelnikov
[APIGW] list app codes of app

What this PR does / why we need it
Which issue this PR fixes

Special notes for your reviewer
Added missing endpoint

Reviewed-by: Artem Lifshits
Reviewed-by: Aloento
[DCAAS]: gateway ipv6 support

What this PR does / why we need it
Added support for IPV6 addresses
Acceptance tests
=== RUN   TestVirtualGatewayListing
--- PASS: TestVirtualGatewayListing (0.51s)
=== RUN   TestVirtualGatewayLifecycle
--- PASS: TestVirtualGatewayLifecycle (2.11s)
=== RUN   TestVirtualGatewayIPV6Lifecycle
--- PASS: TestVirtualGatewayIPV6Lifecycle (2.02s)
PASS

Process finished with the exit code 0

Reviewed-by: Anton Sidelnikov
[DCAAS]: update ipv6

What this PR does / why we need it

Reviewed-by: Anton Sidelnikov
Reviewed-by: Artem Sh.
@sgmv sgmv dismissed stale reviews from artem-lifshits and anton-sidelnikov via 864fd07 May 24, 2024 09:34
artem-lifshits
artem-lifshits previously approved these changes May 24, 2024
@anton-sidelnikov
Copy link
Member

regate

Copy link
Contributor

otc-zuul bot commented May 24, 2024

Build failed.
https://zuul.otc-service.com/t/eco/buildset/571440d941a341cbac5f3ee0efac0577

✔️ otc-golangci-lint SUCCESS in 2m 41s
✔️ golang-make-vet SUCCESS in 2m 59s
✔️ golang-make-test SUCCESS in 3m 27s
golang-make-functional FAILURE in 7m 39s

@sgmv sgmv dismissed stale reviews from artem-lifshits and anton-sidelnikov via de43485 May 24, 2024 10:39
@anton-sidelnikov anton-sidelnikov added post Execute check-post jobs and removed gate Merge PR labels May 24, 2024
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label May 24, 2024
Copy link
Contributor

otc-zuul bot commented May 24, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/4e6a98689ae740479a1184397d006c52

✔️ otc-golangci-lint SUCCESS in 2m 28s
✔️ golang-make-vet SUCCESS in 3m 01s
✔️ golang-make-test SUCCESS in 3m 31s
✔️ golang-make-functional SUCCESS in 7m 32s

@otc-zuul otc-zuul bot merged commit aa5c6cb into devel May 24, 2024
3 checks passed
@otc-zuul otc-zuul bot deleted the dataarts-factory-scripts branch May 24, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gate Merge PR post Execute check-post jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants