[API Update & Refactor] ELB #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aloento
added
documentation
anton-sidelnikov
requested changes
Jul 3, 2023
| @@ -15,8 +15,9 @@ func TestIpGroupList(t *testing.T) { | |||
| client, err := clients.NewElbV3Client() | |||
| th.AssertNoErr(t, err) | |||
|
|
|||
| listOpts := ipgroups.ListOpts{} | |||
| ipgroupsList, err := ipgroups.List(client, listOpts) | |||
| ipgroupsLists, err := ipgroups.List(client, ipgroups.ListOpts{}).AllPages() | |||
There was a problem hiding this comment.
why extract here? Previously it works without it
There was a problem hiding this comment.
All List API returned with pageinfo should warp with Page
|
|
||
| listOpts := ipgroups.ListOpts{} | ||
| ipGroupsSlice, err := ipgroups.List(client, listOpts) | ||
| ipGroupsSlices, err := ipgroups.List(client, ipgroups.ListOpts{}).AllPages() |
There was a problem hiding this comment.
extract and paging should be inside list func
| @@ -18,7 +18,7 @@ func TestLoadBalancerList(t *testing.T) { | |||
| loadbalancerPages, err := loadbalancers.List(client, listOpts).AllPages() | |||
There was a problem hiding this comment.
extract and paging should be inside list func again
There was a problem hiding this comment.
currently no. have to change how the Page struct works.
|
|
||
| listPolicy, err := security_policy.List(client, listOpts) | ||
| allPolicies, err := security_policy.ExtractSecurities(allPages) |
There was a problem hiding this comment.
again extract outside of the function
There was a problem hiding this comment.
I will try, but it is a huge modification for all functions using Page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #512