Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CC-BY-SA icon with SVG #4792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hiddewie
Copy link
Contributor

@hiddewie hiddewie commented May 14, 2024

Part of #850

Split off from #4775

This pull request replaces PNG icons for the CC-BY-SA icons with their minimized SVG variants, to ensure screens with high pixel densities can display the OpenStreetMap website with beautiful graphics.

@hiddewie hiddewie marked this pull request as ready for review May 14, 2024 17:47
@tomhughes
Copy link
Member

It looks like this one has had the whitespace put back?

By the way you might have noticed I've been fixing up your other branches to squash the whitespace change back into the original edit - we like to try and keep a clean history where we can so it would be better to do that here if you are able. It's also better to rebase on master than merge from it.

@AntonKhorev
Copy link
Contributor

Again this is not on a web page, so concerns similar to emails and #4799 (comment) apply.

@hiddewie
Copy link
Contributor Author

For Atom feeds SVGs should work: the RFC notes that the feed:rights tag should be a human readable description, either text or HTML. https://validator.w3.org/feed/docs/rfc4287.html#element.rights. HTML with an image should be valid and work in clients that can display images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants