Feature/dhv3 #138
Merged
Feature/dhv3 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This routes /url/authenticate requests from the Cisco Umbrella CIDRs to a different page. This prevents Cisco from 'logging in' and preventing the user from logging in.
nlsvgtr
approved these changes
Aug 3, 2023
You can now add `blockCidrs` to the client config.
Example:
```
{
"blockCidrs": [
"1.2.3.4/16",
"4.4.4.4/16"
]
}
```
When the `blockCidrs` key does not exist in the client config, the block cidrs default to the Cisco umbrella CIDRs.
Note: This means that if you want to add CIDRs to the block CIDRs, and you want to keep the Cisco Umbrello CIDRs, you have to add those to the client config as well.
Agreed, I've added this, with instructions in the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CIDR-based blocker to prevent e-mail filters (e.g. Cisco Umbrella) from invalidating a login link
Type of change
New feature
Tests
Manually