Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save widgets reload #140

Open
wants to merge 24 commits into
base: development
Choose a base branch
from

Conversation

stijnvandervegt
Copy link
Collaborator

@stijnvandervegt stijnvandervegt commented Jun 19, 2020

Fixed reload widgets after save:

  • accordeon-widgets
  • cookie-warning-widgets
  • date-bar-widgets
  • slide-widgets
  • info-bar-widgets
  • participatory-budgeting-widgets
  • resource-form-widgets
  • resource representation-widgets
  • argument-form-widgets

I've also fixed the timing for the openstad-oauth middleware, so the user will be loaded after a widget save.

- use express middleware with when: afterRequired property (after all middleware shipped with apostrophe-express but before all middleware passed to it as options)
- move logic to lib folder
- use apos.utils.load
- use expressMiddleware
- fix html syntax bug in title tag of deny button
@stijnvandervegt stijnvandervegt marked this pull request as ready for review June 24, 2020 20:19
@ToshKoevoets
Copy link
Collaborator

@stijnvandervegt mooi werk, ik heb alleen zowel de options als widget data uit de attributes gehaald by default. Werd mega groot, dus denk dat we die nog even handmatig toe moeten gaan voegen.

@stijnvandervegt
Copy link
Collaborator Author

@stijnvandervegt mooi werk, ik heb alleen zowel de options als widget data uit de attributes gehaald by default. Werd mega groot, dus denk dat we die nog even handmatig toe moeten gaan voegen.

@ToshKoevoets Ah daar had ik inderdaad nog niet naar gekeken. Maar goed om die standaard uit te zetten. Ik zal alle widgets nalopen en alleen de 'player' data toevoegen die we nodig hebben

@stijnvandervegt
Copy link
Collaborator Author

@ToshKoevoets De playerData heb ik gecheckt en die wordt niet zoveel gebruikt. Daarnaast heb ik de play method ook voor de arguments en arguments-form widgets toegepast. De PR is nu compleet.

ToshKoevoets pushed a commit that referenced this pull request Dec 5, 2021
@nlsvgtr
Copy link
Contributor

nlsvgtr commented Feb 8, 2022

This is very useful and should me merged if ever anyone finds the time to resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants