Skip to content

Commit

Permalink
tox: Correct functional test factors
Browse files Browse the repository at this point in the history
We are running functional tests in zuul without a 'pyNN' factor (e.g.
'tox -e functional'). For this to work, we need to allow an empty
factor, i.e. we want:

  [testenv:functional{,-py310}]

rather than:

  [testenv:functional{-py310}]

(note the missing comma)

Unfortunately we missed this as tox 4 has a currently unaddressed
regression [1] that results in it running the base testenv in the case
there is only a partial factor match. That needs to be fixed for avoid
this biting us again the future, but we can at least fix it for now.

[1] tox-dev/tox#3219

Change-Id: Ib9f65a4523222f1224d51534c5061f90501b59d3
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
  • Loading branch information
stephenfin committed Feb 15, 2024
1 parent c2baf1d commit 568921c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tox.ini
Expand Up @@ -23,7 +23,7 @@ commands =
stestr run {posargs}
stestr slowest

[testenv:functional{-py37,-py38,-py39}]
[testenv:functional{,-py37,-py38,-py39,-py310,-py311,-py312}]
description =
Run functional tests.
# Some jobs (especially heat) takes longer, therefore increase default timeout
Expand Down

0 comments on commit 568921c

Please sign in to comment.