-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bootstrap mysqlrouter action test to mysqlrouter #1082
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a verification test for the bootstrap action that checks that the action does (re-)bootstrap the mysql-router.
0c3b499
to
34205f6
Compare
Please review this case if you have time, thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good; just an issue with potentially very long test times due to endless while
loops.
b2eb830
to
cca9171
Compare
Could somebody review this one? Thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not clear on why the cls.conf_file
has been changed as without a bit more explanation it's not obvious whether the test_910_restart_on_config_change
actually does nothing (i.e. isn't a valid test) as the change to the cls.conf_file
ought to affect the test in some way.
I changed it back to original and I put another variable for specific test. could you please review it? Thanks! |
@ajkavanagh any chance to review this case? I get it back to original and added new variable for only new test. |
Review that tests this: https://review.opendev.org/c/openstack/charm-mysql-router/+/886810